Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventBus could attempt to publish to unsubscribed subscription #6

Closed
rowandh opened this issue Mar 9, 2019 · 2 comments
Closed

EventBus could attempt to publish to unsubscribed subscription #6

rowandh opened this issue Mar 9, 2019 · 2 comments
Labels
bug

Comments

@rowandh
Copy link

rowandh commented Mar 9, 2019

There's a concurrency issue in EventBus.Publish. When enumerating allSubscriptions for publishing, it's possible that a subscription has unsubscribed since allSubscriptions was assigned. This will result in an IndexOutOfBoundsException.

Related to #1.
@mxjones
Copy link
Owner

mxjones commented Apr 3, 2019 •
edited
Loading

Sorry, been busy recently.

Ah yes, you are right. If you fancy taking a stab at it, go ahead otherwise I will try and find some time to look at it at some point.

Are you running into this error frequently?

@mxjones mxjones added the bug label Apr 3, 2019
@mxjones mxjones mentioned this issue Apr 24, 2019
Merged
@mxjones
Copy link
Owner

mxjones commented Apr 24, 2019

I couldn't reproduce this issue myself, but I think it should be fixed with the change in 1.0.6

@mxjones mxjones closed this as completed Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rowandh @mxjones