Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have an ignoredPath option or multiple srcPath #14

Closed
blombard opened this issue Dec 16, 2021 · 6 comments
Closed

Have an ignoredPath option or multiple srcPath #14

blombard opened this issue Dec 16, 2021 · 6 comments

Comments

@blombard
Copy link
Contributor

Hello and thank you for this package 🙂

I'm using this tool in a Nuxtjs app and the folder structure is pretty flat meaning not everything is under app or equivalent.

I would like to run this tool against /components, /pages, ... But since I can't do that, I'm forced to use the root path.

The problem is that the tool is also running in my node_modules so it takes a lot a time and can add some noise to the result.

I was wondering if it was possible to add an ignoredPath option or that srcPath could take an array of string as argument?

I'm willing to help if you can give me a bit of context on where to start 🙂

@mxmvshnvsk
Copy link
Owner

Hi @blombard. Thx for interest. It's good idea, I'll implement this logic in next minor version on next week.

@mxmvshnvsk
Copy link
Owner

@blombard, u can try version 0.7.0, option ignorePaths available in this version.

@blombard
Copy link
Contributor Author

Hello @mxmvshnvsk, thank you for the release!

I added 2 things in a PR: #15

  • The ignorePaths config for missed translations.
  • The fact that the path is ignored if the path includes the ignorePaths and not if it endsWith the ignorePaths.

Because if you want to ignore node_modules this will likely not be the last folder. :)

@mxmvshnvsk
Copy link
Owner

@blombard thx for your pr, I added some comments.

@blombard
Copy link
Contributor Author

Have you submitted your review?

@mxmvshnvsk
Copy link
Owner

Sorry, already submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants