Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with Piqued's "Gate High" parameter #105

Open
w-winter opened this issue Nov 2, 2020 · 0 comments
Open

Bug with Piqued's "Gate High" parameter #105

w-winter opened this issue Nov 2, 2020 · 0 comments

Comments

@w-winter
Copy link

w-winter commented Nov 2, 2020

There are a couple of issues with Piqued's "Gate High" parameter:

(1) The little "gate icon" next to the A/B/C/D channel marker doesn't switch on when you select "Gate High : "Yes". What I've found fixes this is changing https://github.com/mxmxmx/O_C/blob/master/software/o_c_REV/APP_ENVGEN.ino#L570 to read gate_raised_ = gate_raised || get_gate_high();

(2) State changes from "No" to "Yes" only appears to be respected when you switch the channel type (which probably forces all the menu options to be reread), so it's only possible to make one of the looping envelope types (e.g., ADL2) loop using "Gate High" after switching the envelope type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant