Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default behaviour of sudo #135

Closed
iTrooz opened this issue Oct 4, 2022 · 0 comments · Fixed by #138
Closed

Default behaviour of sudo #135

iTrooz opened this issue Oct 4, 2022 · 0 comments · Fixed by #138

Comments

@iTrooz
Copy link
Contributor

iTrooz commented Oct 4, 2022

The default behaviour of sudo (true, to be used every time) is problematic because in some cases, the runner will not have sudo installed, but might already be root (for example containers)

I propose two potential solutions :

  • Set the default value of sudo to false (aren't most runners already run with root ?)
  • Set the default value of sudo to detect, which would not use sudo if the user UID is 0 (already root)

What do you think ? I'd be glad to submit a PR once I get your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant