Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal]: fix that there is XML in the doc comments #159

Closed
2 of 3 tasks
mxschmitt opened this issue Aug 1, 2021 · 5 comments
Closed
2 of 3 tasks

[internal]: fix that there is XML in the doc comments #159

mxschmitt opened this issue Aug 1, 2021 · 5 comments
Labels
p2-bug Something isn't working

Comments

@mxschmitt
Copy link
Member

mxschmitt commented Aug 1, 2021

  • fix that there is XML in the doc comments -> it should not be there (was not correct since a few months)
  • fix that there are csharp examples in the generated_interfaces.go
  • Re-introduce EmulateMedia
@mxschmitt mxschmitt changed the title [internal]: roll follow-ups [internal]: fix that there is XML in the doc comments Aug 3, 2021
@kumaraditya303
Copy link
Contributor

@mxschmitt What XML should be removed, <summary/> from structs ?

@mxschmitt
Copy link
Member Author

@mxschmitt What XML should be removed, <summary/> from structs ?

https://github.com/mxschmitt/playwright-go/blob/master/generated-structs.go

The .NET comment generator should be removed since we want just the text.

@kumaraditya303
Copy link
Contributor

We don't even want cref tags ?

@mxschmitt
Copy link
Member Author

We don't even want cref tags ?

I don't think that's a thing in the Go world, but feel free to verify.

https://blog.golang.org/godoc

@mxschmitt mxschmitt added the p2-bug Something isn't working label Aug 4, 2021
@mxschmitt
Copy link
Member Author

Fixed in #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants