Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement event_breakpoint in nvim-dap #1

Open
mxsdev opened this issue Jul 8, 2022 · 1 comment
Open

Implement event_breakpoint in nvim-dap #1

mxsdev opened this issue Jul 8, 2022 · 1 comment
Labels
enhancement New feature or request nvim-dap Related to nvim-dap

Comments

@mxsdev
Copy link
Owner

mxsdev commented Jul 8, 2022

Unlike many other dap based adapters, vscode-js-debug always communicates breakpoints as initially unverified (rejected), until this is changed layer with the breakpoint event. This is in order to support multiple child sessions, where the rejection status of a breakpoint may not be known until much after the initial setBreakpoints request.

This plugin currently "solves" this problem by hijacking the nvim-dap event loop and setting all breakpoints as initially verified, and then rechecking the status once a continued event is received. This solution is hacky and probably has some edge cases (particularly when there are multiple child sessions of interest).

This is essentially an issue with nvim-dap, so a parallel PR over there will be made eventually. I am cross-posting this here for the sake of tracking the issue.

@mxsdev mxsdev added enhancement New feature or request nvim-dap Related to nvim-dap labels Jul 8, 2022
@mfussenegger
Copy link
Contributor

Does mfussenegger/nvim-dap#620 resolve this or is there more required to get this working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nvim-dap Related to nvim-dap
Projects
None yet
Development

No branches or pull requests

2 participants