Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that ensures we don't import non-types from typescript #22

Closed
mxsdev opened this issue Nov 14, 2022 · 1 comment
Closed

Test that ensures we don't import non-types from typescript #22

mxsdev opened this issue Nov 14, 2022 · 1 comment
Labels
tests vscode Relating to the VSCode Plugin
Milestone
1.0.0

Comments

@mxsdev
Copy link
Owner

mxsdev commented Nov 14, 2022 •
edited

Sometimes the bundle fails in vscode because an extraneous dependency (typescript) is require'd, but is not included in the bundle.

This can probably be accomplished with this eslint rule, but the vscode integration tests should 100% be using the bundled version rather than --extensionDevPath.
@mxsdev mxsdev added vscode Relating to the VSCode Plugin tests labels Nov 14, 2022
@mxsdev mxsdev changed the title Test that ensures we don't import non-types from typescript Test that ensures we don't import non-types from typescript Nov 14, 2022
@mxsdev mxsdev added this to the 1.0.0 milestone Nov 14, 2022
@mxsdev
Copy link
Owner Author

mxsdev commented Nov 20, 2022

I think the best that can be done is with daa3f67, since vscode's testing framework has no mechanism to test an actual bundle.

@mxsdev mxsdev closed this as completed Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests vscode Relating to the VSCode Plugin
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@mxsdev