Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved mapped type tests #29

Closed
wants to merge 1 commit into from
Closed

Conversation

Didas-git
Copy link

Fixes #24

As mentioned in #23 some types will not resolve and this still happens with this tests, as of now im not aware on how i could write the test properly to fail when the type is not resolved, i tried to go on the .tree but felt that i would break the entire test if trying to change it by hand.

I also included the test mentioned in #25 so when custom depth is added this can be tested easily

@mxsdev
Copy link
Owner

mxsdev commented Nov 14, 2022

Wonderful! Only feedback is (and I hate to be that guy) but if you could stick to the camel-case that would be great, if not just for my OCD.

im not aware on how i could write the test properly to fail when the type is not resolved

If you really wanted to, you could write a custom test in tests/other, following in the footsteps of the other tests in that directory. But don't worry about it because I'll probably write a test like that when I implement the feature, since I tend to follow TDD when I can.

@Didas-git
Copy link
Author

Wonderful! Only feedback is (and I hate to be that guy) but if you could stick to the camel-case that would be great, if not just for my OCD.

im not aware on how i could write the test properly to fail when the type is not resolved

If you really wanted to, you could write a custom test in tests/other, following in the footsteps of the other tests in that directory. But don't worry about it because I'll probably write a test like that when I implement the feature, since I tend to follow TDD when I can.

Amazing, i will wait for the feature to be added together with others like #25 that im really excited for.
Hope that this tests can at least help test some more "niche" mapped scenarios later on.

@mxsdev
Copy link
Owner

mxsdev commented Nov 20, 2022

These tests (or equivalents) have been implemented with a21086c.

Thanks again!

@mxsdev mxsdev closed this Nov 20, 2022
@mxsdev mxsdev mentioned this pull request Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better mapped tests
2 participants