Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type tree gets generated on every quick info call #4

Closed
mxsdev opened this issue Oct 28, 2022 · 1 comment
Closed

Type tree gets generated on every quick info call #4

mxsdev opened this issue Oct 28, 2022 · 1 comment
Labels
performance tsserver Relating to the TypeScript server plugin

Comments

@mxsdev
Copy link
Owner

mxsdev commented Oct 28, 2022

The TypeInfo tree will be generated on every call to getQuickInfo on the typescript server. This can potentially cause enormous slowdowns on hovers in VSCode.

Ideally, the tsserver plugin would generate a type tree only upon a quick info call originating from the extension.
@mxsdev mxsdev added bug Something isn't working performance tsserver Relating to the TypeScript server plugin and removed bug Something isn't working labels Oct 28, 2022
@mxsdev
Copy link
Owner Author

mxsdev commented Oct 29, 2022

Fixed for now in 0d18d5c

I basically just hijacked completionInfo instead of quickInfo, since you can send custom packets through the former. It's pretty gross, but I don't really see a better way to do it (without running a second instance of tsserver).

@mxsdev mxsdev closed this as completed Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance tsserver Relating to the TypeScript server plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mxsdev