Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OfflinePlugin fixes and improvments #378

Merged
merged 2 commits into from
May 24, 2016
Merged

Conversation

NekR
Copy link
Contributor

@NekR NekR commented May 23, 2016

  • Remove relativePaths: true because it's true by default
  • Add safeToUseOptionalCaches: true to remove warnings about additional caches
  • Make AppCache cache both sections: main and additional

* Remove `relativePaths: true` because it's `true` by default
* Add `safeToUseOptionalCaches: true` to remove warnings about additional caches
* Make AppCache cache both sections: `main` and `additional`
@mxstbr
Copy link
Member

mxstbr commented May 23, 2016

Awesome, thanks! Two small linting errors, then we can merge:

react-boilerplate\internals\webpack\webpack.prod.babel.js
  101:39  error  Missing trailing comma  comma-dangle
  102:8   error  Missing trailing comma  comma-dangle

✖ 2 problems (2 errors, 0 warnings)

@NekR
Copy link
Contributor Author

NekR commented May 23, 2016

Yeah, sorry, forgot to run tests. I'll fix it once get back to computer.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.417% when pulling c8eec3d on NekR:v3.0.0 into 534f988 on mxstbr:v3.0.0.

@mxstbr
Copy link
Member

mxstbr commented May 24, 2016

Awesome, thanks @NekR!

@mxstbr mxstbr merged commit d8b2053 into react-boilerplate:v3.0.0 May 24, 2016
@ghost
Copy link

ghost commented May 25, 2016

@mxstbr are you sure you wanted to merge ino mxstbr:v3.0.0 ?

@mxstbr
Copy link
Member

mxstbr commented May 26, 2016

Oooh no, my bad. Would you mind resubmitting this PR against the master branch?

@NekR
Copy link
Contributor Author

NekR commented May 26, 2016

Wow. Have you merged v3 to master while I was doing this PR? I'll resubmit
it, no problem.
On May 26, 2016 09:02, "Max Stoiber" notifications@github.com wrote:

Oooh no, my bad. Would you mind resubmitting this PR against the master
branch?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#378 (comment)

@mxstbr
Copy link
Member

mxstbr commented May 26, 2016

We released v3 a week ago! 🎉

@lock
Copy link

lock bot commented May 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants