-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OfflinePlugin fixes and improvments #378
Conversation
* Remove `relativePaths: true` because it's `true` by default * Add `safeToUseOptionalCaches: true` to remove warnings about additional caches * Make AppCache cache both sections: `main` and `additional`
Awesome, thanks! Two small linting errors, then we can merge: react-boilerplate\internals\webpack\webpack.prod.babel.js
101:39 error Missing trailing comma comma-dangle
102:8 error Missing trailing comma comma-dangle
✖ 2 problems (2 errors, 0 warnings) |
Yeah, sorry, forgot to run tests. I'll fix it once get back to computer. |
Awesome, thanks @NekR! |
@mxstbr are you sure you wanted to merge ino |
Oooh no, my bad. Would you mind resubmitting this PR against the master branch? |
Wow. Have you merged v3 to master while I was doing this PR? I'll resubmit
|
We released v3 a week ago! 🎉 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
relativePaths: true
because it'strue
by defaultsafeToUseOptionalCaches: true
to remove warnings about additional cachesmain
andadditional