Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whatsapp icon is all white in solid circle mode #63

Closed
siddharthkp opened this issue Sep 22, 2016 · 3 comments
Closed

Whatsapp icon is all white in solid circle mode #63

siddharthkp opened this issue Sep 22, 2016 · 3 comments

Comments

@siddharthkp
Copy link

siddharthkp commented Sep 22, 2016

Check out this share button - The whatsapp icon is all white.

screen shot 2016-09-22 at 8 54 12 pm

This is because the whatsapp logo has white instead of transparent. Compare it with the twitter logo.

screen shot 2016-09-22 at 8 59 44 pm screen shot 2016-09-22 at 9 00 01 pm

Digging deeper, it seems the way it is structured. The whatsapp logo has an extra white path on it.

screen shot 2016-09-22 at 9 05 07 pm screen shot 2016-09-22 at 9 05 38 pm

There are two things I can think of -

  1. Make another svg which only is only made of black strokes leaving the icon in transparent. (Sorry, I can't help you with that)
  2. Use a png instead.

@mxstbr, What do you think?

@olets olets added the bug label Sep 22, 2016
@mxstbr
Copy link
Owner

mxstbr commented Sep 23, 2016

Definitely want to stick with SVG, I'd much rather edit the SVG to make this work. Not an expert myself though.

(@una mentioned on Twitter about looking for open source projects to contribute to, this might be a good first bug?)

@siddharthkp
Copy link
Author

@mxsbtr, that's how I landed here 😄
Not sure if this is a beginner's bug though, you need some svg wizardry

@siddharthkp
Copy link
Author

But, maybe I can source it from somewhere. Self assigning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants