-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To run ScrapydWeb in HTTPS mode #18
Comments
Maybe adding config paths for the certificate files and optionally adding them here: Would be enough? You might also need to require app.run with ssl_context:
|
This works for me, and no need to install pyopenssl. Could you try and tell me your result?
|
It seems to work :) |
What's the file type of your certificate? (Mine is '.pem') |
Fixed in v1.1.0: Now you can set up ENABLE_HTTPS, CERTIFICATE_FILEPATH, and PRIVATEKEY_FILEPATH to enable HTTPS mode. |
Just wanted to point out to anyone having issues with SSL that scrapydweb uses Popular certificate aggregators like LetsEncrypt chmod the certificate as root only read/write. That means you will need to run scrapydweb as root in order for the certificate to parse. |
The below assert line could be commented out. scrapydweb/scrapydweb/utils/check_app_config.py Lines 84 to 91 in 7a3b81d
|
Thanks @my8100 👍 I can't think of a clean way to fix this issue other than acknowledging the file exists manually and commenting out that line as you say, would you agree?
Kind of leaves you in no man's land. Thanks for a great tool by the way @my8100 and hello from Australia! |
@jwjhdev scrapydweb/scrapydweb/default_settings.py Lines 82 to 92 in 7a3b81d
|
How do i enable https? I have a certificate file from let's encrypt and would like to start the server using https.
Is this possible at this time? It should be possible since using basic auth without HTTPS is dangerous.
The text was updated successfully, but these errors were encountered: