Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename to lexicon ids (#1127) #1127

Merged
merged 22 commits into from
Dec 24, 2023
Merged

Conversation

myConsciousness
Copy link
Owner

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for new/updated/fixed functionality.
  • I have updated/added dartdoc comments with ///.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for jade-haupia-45bdc2 canceled.

Name Link
🔨 Latest commit 849f62f
🔍 Latest deploy log https://app.netlify.com/sites/jade-haupia-45bdc2/deploys/6587e8b37358fc0008511f72

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 99 lines in your changes are missing coverage. Please review.

Comparison is base (916f6ed) 82.53% compared to head (849f62f) 79.53%.

Files Patch % Lines
...ackages/bluesky/lib/src/services/feed_service.dart 77.94% 43 Missing ⚠️
...ckages/bluesky/lib/src/services/graph_service.dart 89.26% 16 Missing ⚠️
.../atproto_core/lib/src/clients/service_context.dart 31.25% 11 Missing ⚠️
packages/bluesky/lib/src/bluesky.dart 68.00% 8 Missing ⚠️
...ackages/atproto/lib/src/services/repo_service.dart 88.23% 6 Missing ⚠️
...ckages/bluesky/lib/src/services/actor_service.dart 85.00% 6 Missing ⚠️
packages/atproto/lib/src/atproto.dart 71.42% 4 Missing ⚠️
...ckages/atproto/lib/src/services/label_service.dart 62.50% 3 Missing ⚠️
...ages/bluesky/lib/src/services/service_context.dart 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
- Coverage   82.53%   79.53%   -3.01%     
==========================================
  Files         359      355       -4     
  Lines        4249     4471     +222     
==========================================
+ Hits         3507     3556      +49     
- Misses        742      915     +173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added test bluesky A label indicating the package `bluesky`. labels Dec 21, 2023
@github-actions github-actions bot added bluesky_cards A label indicating the package `bluesky_cards`. bluesky_text A label indicating the package `bluesky_text`. labels Dec 22, 2023
@myConsciousness
Copy link
Owner Author

Change BaseXRPCService so that it's not extended, but rather initialized only once by a specific service object, such as Bluesky, and used by each service.

@github-actions github-actions bot added the atproto A label indicating the package `atproto`. label Dec 22, 2023
@myConsciousness myConsciousness changed the title refactor: Rename to lexicon ids refactor: Rename to lexicon ids (#1127) Dec 24, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation atproto_core A label indicating the package `atproto_core`. atproto_test A label indicating the package `atproto_test`. labels Dec 24, 2023
@github-actions github-actions bot added the did_plc A label indicating the package `did_plc`. label Dec 24, 2023
@myConsciousness myConsciousness merged commit 79e832d into main Dec 24, 2023
19 of 20 checks passed
@myConsciousness myConsciousness deleted the refactor-method-names branch December 24, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atproto_core A label indicating the package `atproto_core`. atproto_test A label indicating the package `atproto_test`. atproto A label indicating the package `atproto`. bluesky_cards A label indicating the package `bluesky_cards`. bluesky_text A label indicating the package `bluesky_text`. bluesky A label indicating the package `bluesky`. did_plc A label indicating the package `did_plc`. documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants