Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default_log_printer_test.dart #195

Merged
merged 3 commits into from May 22, 2022
Merged

Update default_log_printer_test.dart #195

merged 3 commits into from May 22, 2022

Conversation

myConsciousness
Copy link
Member

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@github-actions github-actions bot added the do not merge yet For do-not-merge checker label May 22, 2022
Copy link
Member Author

@myConsciousness myConsciousness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed

@github-actions github-actions bot removed the do not merge yet For do-not-merge checker label May 22, 2022
@github-actions
Copy link

Congratulations, this pull request has been reviewed and is ready for merging!

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #195 (cf5aad7) into main (7db467c) will decrease coverage by 28.55%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #195       +/-   ##
===========================================
- Coverage   83.55%   55.00%   -28.56%     
===========================================
  Files         115       65       -50     
  Lines        1958      700     -1258     
===========================================
- Hits         1636      385     -1251     
+ Misses        322      315        -7     
Impacted Files Coverage Δ
test/src/log/printer/default_log_printer_test.dart
test/src/http/request_test.dart
test/src/job/error/schedule_parse_error_test.dart
test/src/job/branch/branch_test.dart
test/src/banner/banner_test.dart
test/src/job/config/retry_configuration_test.dart
test/src/job/task/pararrel_task_test.dart
test/src/log/input_log_event_test.dart
test/src/job/task/shutdown_task_test.dart
test/src/diagnostics/name_relation_test.dart
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd2da8...cf5aad7. Read the comment docs.

@myConsciousness
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented May 22, 2022

Build succeeded:

@bors bors bot merged commit 7fdb4b7 into main May 22, 2022
@bors bors bot deleted the myConsciousness-patch-2 branch May 22, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants