Skip to content

Commit

Permalink
Don't include URL helpers at the top level.
Browse files Browse the repository at this point in the history
This caused the test suite to fail at the initialization phase with ruby 1.9.3
and test-unit 3.0.9. It was fine with other combinations. The fix reflects best
practice.
  • Loading branch information
hainesr committed Feb 27, 2015
1 parent 9374c8e commit 1ff27d6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 1 addition & 2 deletions test/test_helper.rb
@@ -1,5 +1,5 @@
#------------------------------------------------------------------------------
# Copyright (c) 2013, 2014 The University of Manchester, UK.
# Copyright (c) 2013-2015 The University of Manchester, UK.
#
# BSD Licenced. See LICENCE.rdoc for details.
#
Expand Down Expand Up @@ -30,7 +30,6 @@
end

class ActiveSupport::TestCase
include TavernaPlayer::Engine.routes.url_helpers
include ActionDispatch::TestProcess
fixtures :all
end
4 changes: 3 additions & 1 deletion test/unit/helpers/taverna_player/runs_helper_test.rb
@@ -1,5 +1,5 @@
#------------------------------------------------------------------------------
# Copyright (c) 2013, 2014 The University of Manchester, UK.
# Copyright (c) 2013-2015 The University of Manchester, UK.
#
# BSD Licenced. See LICENCE.rdoc for details.
#
Expand All @@ -14,6 +14,8 @@

module TavernaPlayer
class RunsHelperTest < ActionView::TestCase
include TavernaPlayer::Engine.routes.url_helpers

setup do
@int1 = taverna_player_interactions(:one)
@int2 = taverna_player_interactions(:two)
Expand Down

0 comments on commit 1ff27d6

Please sign in to comment.