Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should refactor and remove old JS that we no longer need in vendor/assets/javascripts #405

Closed
7 tasks done
remomueller opened this issue Mar 3, 2015 · 1 comment
Closed
7 tasks done

We should refactor and remove old JS that we no longer need in vendor/assets/javascripts #405

remomueller opened this issue Mar 3, 2015 · 1 comment
Assignees
@remomueller
Labels
Refactoring
Milestone
8.0

Comments

@remomueller
Copy link
Member

We recently ran into an issue where these older JS caused issues in browsers like IE9 due to non-cross browser compatible JS.

We should check each and remove if we think we no longer need it:

In vendor/assets/javascript

  • bloodhound.js
  • bootbox.min.js
  • bootstrap-tagsinput.js
  • bootswatch.js
  • chosen.jquery.js
  • placeholders.jquery.min.js (See issue IE9 password field disappears #403)
  • typeahead-addresspicker.js
@remomueller remomueller added this to the 5.1 milestone Mar 3, 2015
@krand7 krand7 removed this from the 5.1 milestone Mar 13, 2015
@remomueller remomueller added this to the 8.0 milestone Jul 29, 2015
@remomueller remomueller self-assigned this Jul 29, 2015
remomueller added a commit that referenced this issue Jul 29, 2015
@remomueller
Removed Bootswatch JS and Theme page, addresses #405.
be281df
remomueller added a commit that referenced this issue Jul 29, 2015
@remomueller
Removed Bloodhound, and typeahead-addresspicker JS, addresses #405.
c612834 
Also removed unused QuestionsController
remomueller added a commit that referenced this issue Jul 29, 2015
@remomueller
Removed bootbox JS, addresses #405.
10b913a
remomueller added a commit that referenced this issue Jul 29, 2015
@remomueller
Removed bootstrap-tagsinput JS, addresses #405.
2204b7d
remomueller added a commit that referenced this issue Jul 29, 2015
@remomueller
Removed chosen JS and CSS, addresses #405.
2e599c6
@remomueller
Copy link
Member Author

Looks like the following are still being used (and won't be removed at this time):

  • d3.min.js
    • On Engagement Admin Graphs (and potentially elsewhere)
  • jquery.PrintArea.js
    • On Consent and Privacy Policy
  • jquery.slimscroll.js
    • On Consent
  • typeahead.js
    • on Settings -> Gender Autocomplete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remomueller remomueller

Labels
Refactoring
Milestone
8.0
Development

No branches or pull requests
2 participants
@remomueller @krand7