New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future Timestamps are always displayed as "in XXXXX minutes" #1780

Closed

Destroy666x opened this issue Jan 25, 2015 · 2 comments

Labels

b:1.8 s:resolved t:bug

Milestone

Contributor

Destroy666x commented Jan 25, 2015

Currently there is a problem with displaying future timestamps in MyBB.

The only location where future timestamps seem to be displayed in "relative" format, is when a user opens his usercp and sees his own warning end times. Currently it will always be displayed in minutes, even if it is months in the future.

This will only happen in usercp.php reviewing your own warnings, not in warnings.php, where e.g. moderators would check the warnings of a user (there the time is always displayed in the "normal" date/time format that was used in MyBB 1.6.

The problem is the logic for the new relative timestamp format and very easy to fix.

Here is a matching pull request that fixes the problem with very small changes:

Original thread: Future Timestamps are always displayed as "in XXXXX minutes"

Destroy666x added t:bug s:confirmed b:1.8 s:resolved and removed s:confirmed labels

Destroy666x added this to the 1.8.4 milestone

Destroy666x closed this as completed

Contributor

Sama34 commented Jan 25, 2015

Shouldn't warnings and similar use the nice_time funtion used for expiration dates, etc?

Sama34 reopened this

Contributor Author

Destroy666x commented Jan 25, 2015

@Sama34, I guess so, but that's another issue not connected with this my_date() bug. So I'd probably open another ticket for that.

Sama34 mentioned this issue

Warnings, suspention times, etc. Should use the nice_time function. #1783

Closed

Sama34 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment