Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Security Question Language #3519

Open
Ben-MyBB opened this issue Dec 4, 2018 · 6 comments

Comments

@Ben-MyBB
Copy link
Member

commented Dec 4, 2018

The security questions should be shown in the board language that the user is viewing.

https://community.mybb.com/thread-220910.html

@effone

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

Security questions are unique to administrators and the translators don't know which question the administrator is about to put. This will lead to an open end to the translators and the translations will not cover this aspect; hence it will be off-way to how translations are being done now.
This will put the creation / modification of questions hard. Currently it can be created / edited through ACP interface. Changing questions in language files will be more like core file edits.
I don't know whether generation of language files through ACP interface will be a good idea ...

@Ben-MyBB

This comment has been minimized.

Copy link
Member Author

commented Dec 5, 2018

I'm going to defer to one of the developers who will be able to discuss the full logistics (@mybb/developers) but if a user selects a different language as default and the security question is set in the ACP in English the end user wouldn't be able to complete it. It is definitely something we have to explore imo.

@Sama34

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

I agree there is a need to enhance this. One suggestion I would give is to enhance the languages module to some extend.

By default MyBB should add an empty language file once the first question is created (if this is done during installation then there it should be done as well) as including these files in the official package will cause all changes to be missed during upgrades.

Inside such files variables should be automatically added for every custom question (if variable already exists, then ignore).

During registration the system will try to load the file and use the variables for the output, and if the language string for any question is empty then the DB strings should be used.

Sound kind of complicated, but we can't simply ignore the inability to translate any not end-user generated content.

If this is included it should then be done in some way for it to be easy to expand the idea to other modules as well.

@effone

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

If you are talking about system modified special language files then I am completely agreed with you.
To extend this, I always felt an interface for modifying language files is lacking in MyBB. Note that language customization is not limited to language only (en, es, ar) its about expression as well. If someone wants to customize welcome string in English only - he has to land up to kinda core edit ... (editing language file).

@ckoecher

This comment has been minimized.

Copy link

commented Jan 5, 2019

@effone There is an interface for modifying language files in the ACP. Just look in Configuration > Languages.

@effone

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

Ya, but does it allow addition of new variables and expressions?
If yes, then half of the work is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.