Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forum subscriptions do not honor last visit #4106

Closed
andrewjs18 opened this issue Jul 1, 2020 · 9 comments
Closed

forum subscriptions do not honor last visit #4106

andrewjs18 opened this issue Jul 1, 2020 · 9 comments
Labels
b:1.8 Branch: 1.8.x s:duplicate Status: Duplicate. Has been reported already, issue for the same exists t:bug Type: Bug. An issue causing error / flaw / malfunction

Comments

@andrewjs18
Copy link
Contributor

on my 1.8.22 board, the forum subscriptions do not seem to honor the last visit to prevent forum subscriptions from being emailed out, even if someone hasn't visited the forum in months or years.

confirmed by mybb team member, noyle.

Original thread: forum subscriptions do not honor last visit

@andrewjs18 andrewjs18 added b:1.8 Branch: 1.8.x s:confirmed Status: Confirmed. Retested and found the issue exists t:bug Type: Bug. An issue causing error / flaw / malfunction labels Jul 1, 2020
@dvz
Copy link
Contributor

dvz commented Jul 1, 2020

may have become a feature at this point (and be used as a channel to preview content as it appears, like RSS)

@andrewjs18
Copy link
Contributor Author

may have become a feature at this point (and be used as a channel to preview content as it appears, like RSS)

what happens if someone doesn't remove their forum subscription(s), yet 'leaves' the forum by simply changing their email address into something that doesn't exist?

that's how I came across this issue after switching to a different email solution. I started getting a ton of bounce backs for email addresses that did not exist.

@rajat315315
Copy link
Contributor

rajat315315 commented Jul 1, 2020

Good Point.

I think we should put a check when sending emails that if a user hasn't re-visited the forum he has subscribed to in last "X" months, he should be unsubscribed.
Now, X can be 3 months, 6 months, or 1 year.

@dvz
Copy link
Contributor

dvz commented Jul 1, 2020

We also mentioned adding a feature to recognize bounce messages, but we can make it send a message with a confirmation link after a configured time has passed since last visit.

@andrewjs18
Copy link
Contributor Author

Good Point.

I think we should put a check when sending emails that if a user hasn't re-visited the forum he has subscribed to in last "X" months, he should be unsubscribed.
Now, X can be 3 months, 6 months, or 1 year.

I'm not sure that I'd go as far as removing the subscriptions, but certainly stopping the emails after X amount of inactivity on the forums would probably suffice and be the easier solution. doesn't the PM system stop sending email alerts about new messages until you visit the forum again?

@andrewjs18
Copy link
Contributor Author

We also mentioned adding a feature to recognize bounce messages, but we can make it send a message with a confirmation link after a configured time has passed since last visit.

I've been chatting with @yuliu a lot about the mybb mail system, he mentioned something like this, perhaps piggybacking on your thoughts here.

if the user fails to confirm their email address through the link, would it stop all future email messages from being sent out?

@dvz
Copy link
Contributor

dvz commented Jul 1, 2020

I'd imagine saving a status of no activity, rather than invalidating e-mail addresses. Non-critical messages like subscription summaries would then check that before sending mail.

@andrewjs18
Copy link
Contributor Author

I'd imagine saving a status of no activity, rather than invalidating e-mail addresses. Non-critical messages like subscription summaries would then check that before sending mail.

I can get behind that..it'll help cut down on forum email clutter and potentially prevent an IP address from getting on a spam list.

@yuliu
Copy link
Member

yuliu commented Nov 6, 2020

#4160

@yuliu yuliu closed this as completed Nov 6, 2020
@yuliu yuliu added s:duplicate Status: Duplicate. Has been reported already, issue for the same exists and removed s:confirmed Status: Confirmed. Retested and found the issue exists labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b:1.8 Branch: 1.8.x s:duplicate Status: Duplicate. Has been reported already, issue for the same exists t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Development

No branches or pull requests

4 participants