Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LESS CSS Support #62

Closed
ghost opened this issue Apr 25, 2013 · 3 comments
Closed

LESS CSS Support #62

ghost opened this issue Apr 25, 2013 · 3 comments

Comments

@ghost
Copy link

ghost commented Apr 25, 2013

IMO, MyBB should implement LESS support into the theme editor, even if it's like the code that @euantor posted on the forums where it gets transformed into pure CSS on commit.

Should be beneficial to theme authors, especially if it is transformed into CSS - that makes it easier for the end user to understand, instead of staring at a foreign syntax. Of course, if the user doesn't know what LESS is, they can simply use CSS.

Of course, one problem I encountered (and haven't fixed yet) is that variables don't get carried over sessions, so saving and reopening the stylesheet will cause variables to be parsed and lost.

What do you think? I tested it, adding in support on Stylesheet Creation and Editing only took about six lines of code, plus an extra file (the lessc.inc.php Euan posted).

@amwelles
Copy link

amwelles commented Oct 3, 2013

I'm partial to SASS, but that's just me.

@nmalcolm
Copy link
Contributor

nmalcolm commented Jan 5, 2014

Due to the amount of different CSS extensions and the fact we're currently not using any (and might not in the future; I don't think we've ever discussed such as thing for 2.0), I don't feel we should include something like this in 1.8. It's a step forward and a step back. It probably would be useful to some people but supporting it could become problematic especially as MyBB has been pretty self contained. Introducing large features based on external projects with lack of knowledge of how they work generally is a bad idea.

@nmalcolm nmalcolm closed this as completed Jan 5, 2014
@euantorano
Copy link
Member

Definitely agreed @nmalcolm. It's a bit too big of a step to make in the core in 1.8. We could, however possibly look at adding the required hook(s) to achieve support via a plugin for preprocessors such as LESS, SASS etc. Thoughts on that option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants