fix: wait queue/task finished on stopTranscribe #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhen0409
changed the title
|
I had an issue that sometimes after I call stop, the capturing isn't being updated to false, can this be related to that? not sure how to reproduce yet to open a issue, not happening often |
I think it's not related to this PR. I can check this out, currently it check the state before stop the audio queue, and can't promising not has some side effect. |
jhen0409
changed the title
jobpaardekooper
added a commit
to jobpaardekooper/whisper.rn
that referenced
this pull request
Sep 7, 2023
jobpaardekooper
added a commit
to jobpaardekooper/whisper.rn
that referenced
this pull request
Sep 7, 2023
jhen0409
pushed a commit
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107.
Currently we used
encoder_begin_callbackfor the abort method, but it does not directly terminate the thread. This PR change the context uses an own dispatch_queue_t & wait it finished on stop method or release.It probably have the same issue on Android, I'll investigating for it later.
[ ] Release queue on invalidating