Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): update async stop func to match #119 #121

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

jobpaardekooper
Copy link
Contributor

Update the types in the docs and typescript of all the stop functions to make them return a Promise to match the changes from #119.

Copy link
Member

@jhen0409 jhen0409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@jhen0409 jhen0409 merged commit c0fba73 into mybigday:main Sep 7, 2023
2 checks passed
@jobpaardekooper jobpaardekooper deleted the docs-stop-promise branch September 7, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants