feat: sync whisper.cpp (enable ggml-alloc) #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
My test results in iPhone 13 Pro Max & iPad Air 5: ggerganov/whisper.cpp#1270 (comment) |
|
Do you need more testing for this to move forward? Maybe I can help or something. |
|
I want to finish ggerganov/whisper.cpp#1293 before enable Metal. We can still sync whisper.cpp first for ggml-alloc, but GGML_USE_METAL will not be enabled for the time being. |
jhen0409
changed the title
jhen0409
commented
Oct 5, 2023
cpp/coreml/whisper-encoder.mm
Outdated
| MLModelConfiguration *config = [[MLModelConfiguration alloc] init]; | ||
| config.computeUnits = MLComputeUnitsCPUAndGPU; | ||
| //config.computeUnits = MLComputeUnitsCPUAndNeuralEngine; | ||
| //config.computeUnits = MLComputeUnitsAll; |
There was a problem hiding this comment.
We may keep use MLComputeUnitsAll (considering make a param for that), because the ANE performance may be better than GPU on iOS devices.
jhen0409
force-pushed
the
test-alloc-and-metal
branch
from
55bb054
to
1ce6701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ggerganov/whisper.cpp#1270
It can be tested by running
example/ornpm install https://github.com/mybigday/whisper.rn#test-alloc-and-metal.