Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document #46 #52

Closed
theofidry opened this issue Sep 21, 2016 · 3 comments
Closed

Document #46 #52

theofidry opened this issue Sep 21, 2016 · 3 comments

Comments

@theofidry
Copy link
Collaborator

Besides documenting it, I would even recommend it. IMO the biggest selling point of DeepCopy is it's ease of use even on array structures. I don't really like the OOP usage of it and prefer to put it in a function instead like in alice: https://github.com/nelmio/alice/blob/master/src/functions.php#L12

However that's it: I use it because it's convenient. The other selling point of the library is handling cycling graph, but 9/10 a cycling graph is due to a mistake somewhere. Not that there isn't legitimate use cases, but they are very rare.

@mnapoli
Copy link
Member

mnapoli commented Sep 22, 2016

I'm all for it 👍

I just discovered you are using this library in alice, that's really great!

@theofidry
Copy link
Collaborator Author

I just discovered you are using this library in alice, that's really great!

I dare say I'm over using it 😄

theofidry added a commit to theofidry/DeepCopy that referenced this issue Oct 16, 2017
@theofidry theofidry mentioned this issue Oct 16, 2017
@theofidry
Copy link
Collaborator Author

Closed by #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants