Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in cancel handler #9

Closed
nevercast opened this issue Feb 8, 2018 · 1 comment
Closed

Possible bug in cancel handler #9

nevercast opened this issue Feb 8, 2018 · 1 comment

Comments

@nevercast
Copy link

nevercast commented Feb 8, 2018

https://github.com/MycroftAI/mycroft-timer/blob/master/__init__.py#L201

I don't see duration defined in this function, no nonlocal, global or self reference either.

I suspect it was copied from something like this https://github.com/MycroftAI/mycroft-timer/blob/master/__init__.py#L167-L168

In which case, intent['duration'] should be used.

@penrods
Copy link
Collaborator

penrods commented Feb 17, 2018

Fixed by #10

@penrods penrods closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants