Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerSideMap fails to sync in the presence of the RRRCore mod #43

Closed
thecsapprentice opened this issue Jul 21, 2021 · 4 comments
Closed

Comments

@thecsapprentice
Copy link

Hi!

I've been having some trouble getting my server's mods set up, in particular ServerSideMap. After some experimentation today, I was able to confirm that the trouble seems to arise from including the RRRCore mod (https://valheim.thunderstore.io/package/neurodr0me/RRRCore/).

The server logs don't seem to indicate any errors happening, but the client is a different story. I get an ugly looking traceback in the logs when it, presumably, tries to sync. This ultimately fails for some reason and the map on the client is not updated, though otherwise the game appears unaffected by the error.

I'd love to get both of these working together at some point, and hopefully the logs provided help with that. Please let me know if I can provide any additional information.

Server Log:
https://gist.github.com/thecsapprentice/ba00963be44f87f9187c1db512f74bf2

Client Log (Error around line 709):
https://gist.github.com/thecsapprentice/00624e09f4724ffabc65d050dccfcc64

@Mydayyy
Copy link
Owner

Mydayyy commented Jul 21, 2021

Greetings,

I hope you had a pleasant day.

From the pure look at the clientlogs, this issue could very well be the one I may have fixed in an earlier release candidate. Unfortunately, I do have a few unreleased versions of SSM lying on Github here which never got released due to a lack of testing.

Can you try the following:

This RC contains an earlier bugfix regarding Better Continents which might help with RRRCore too.

Best Regards
Mydayyy

@thecsapprentice
Copy link
Author

Mydayyy,

Awesome! This seems to have solved the issue for moment! Maps appear to be syncing properly again, though I haven't tested pins yet. I'll need to do more work and see if integrating the full stack of mods breaks stuff again, but I'm hopeful it will be stable overall.

I'm guessing the changes in the RC have something to do with network code that conflicts with other mods, like RRRCore or BetterWorlds? Hopefully this will get a chance to migrate to the next official release soon!

Thanks!

@Mydayyy
Copy link
Owner

Mydayyy commented Jul 23, 2021

Hey,

I'm guessing the changes in the RC have something to do with network code that conflicts with other mods, like RRRCore or BetterWorlds? Hopefully this will get a chance to migrate to the next official release soon!

I was running into a race condition to be exact. Accessing a variable which was (usually) available. Certain mods which add some networking (e.g extend the handshake) delayed the initialization of that variable - meaning I had to wait for that.

Awesome! This seems to have solved the issue for moment! Maps appear to be syncing properly again, though I haven't tested pins yet. I'll need to do more work and see if integrating the full stack of mods breaks stuff again, but I'm hopeful it will be stable overall.

Apart from the one report which unfortunately, I never was able to reproduce in practice or in theory - the RC should be fully functional, I tested it and everything worked.

Best Regards
Mydayyy

@Mydayyy
Copy link
Owner

Mydayyy commented Sep 19, 2021

Went live in 1.3.5

@Mydayyy Mydayyy closed this as completed Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants