Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon doesn't work for me #17

Closed
alexborovkov opened this issue Jul 5, 2018 · 23 comments
Closed

Addon doesn't work for me #17

alexborovkov opened this issue Jul 5, 2018 · 23 comments

Comments

@alexborovkov
Copy link

I've got TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.

@mydea
Copy link
Owner

mydea commented Jul 9, 2018

Did you get this from tests? In a regular app, an addon or in an engine? I had a similar issue with tests in an engine, which I was able to fix like this: ember-engines/ember-engines#525 (comment)

@alexborovkov
Copy link
Author

I get this from regular app.

@mydea
Copy link
Owner

mydea commented Jul 9, 2018

Just when running it, or during tests? Could you copy the content of your package.json in here? And maybe the full stack trace of the error?

@alexborovkov
Copy link
Author

I've installed ember-basic-dropdown and error gone. But when I select some value in calendar, input value doesn't update.
I use default config
{{date-picker range=true action=(action 'updateDate')}}

@alexborovkov
Copy link
Author

@mydea It seems that action 'updateDate' doesn't trigger

@alexborovkov
Copy link
Author

I've set renderInPlace=true and this solve the problem.

@mydea
Copy link
Owner

mydea commented Jul 9, 2018

None of this should really be necessary. ember-basic-dropdown should be included via the dependencies, and the action should normally work - I tried again in the dummy app, where everything works fine. Which versions of ember and ember-cli are you using?

@alexborovkov
Copy link
Author

alexborovkov commented Jul 9, 2018

"ember-source": "2.13.3",
"ember-cli": "2.11.0",

Also I can't select month and year. I think this related to renderInPlace option too. I suppose you need to transfer this option to inner date-picker-month-year-select component.

@mydea
Copy link
Owner

mydea commented Jul 9, 2018

Sadly, I really can't replicate this - does e.g. ember-power-select work for you?

@alexborovkov
Copy link
Author

What do you mean? Replace ember-basic-dropdown to ember-power-select ?

@mydea
Copy link
Owner

mydea commented Jul 10, 2018

No, I mean if other addons using ember-basic-dropdown work. Or if using ember-basic-dropdown directly works?

@stepanushariara
Copy link

Hi Guys,
I use ember-date-component but everytime i click it then always get errror like this picture.
How to solve this ??

screen shot 2018-08-09 at 4 45 39 pm

@mydea
Copy link
Owner

mydea commented Aug 9, 2018

Can you tell me:

  1. What version of ember-date-components you are using
  2. What version of ember-basic-dropdown you are using (if you use yarn, you can find the exact version in the yarn.lock file, or you could just look into your node_modules folder and search for it there, in the package.json file you'll see the version)
  3. Anything special about your env? How you start it, which environment (development/test/...)?

Also, does this code work for you, if you put it in a template:

{{#basic-dropdown as |dropdown|}}
  {{#dropdown.trigger}}Click me{{/dropdown.trigger}}
  {{#dropdown.content}}Content of the trigger{{/dropdown.content}}
{{/basic-dropdown}}

@stepanushariara
Copy link

  1. I use ember-date-component 1.1.2

  2. In my package.json there is no ember-basic-dropdown
    But, in package-lock.json there is ember-basic-dropdown 0.34.0 as a dependency of ember-date-component

  3. I just use default setting ember.

Not yet, let me try

@mydea
Copy link
Owner

mydea commented Aug 9, 2018

This addon depends on ember-basic-dropdown 1.x (which is also in its dependencies) - maybe some other addon or similar uses ember-basic-dropdown 0.34? I guess this could lead to this issue.

@stepanushariara
Copy link

So what should i do?

Should i install ember-basic-dropdown by package.json or modified the dependencies by package-lock.json??

@stepanushariara
Copy link

After i upgrade to version 1.1.5 (ember-basic-dropdown 1.0.0) then i got error like this when i click it

screen shot 2018-08-10 at 12 13 57 pm

@stepanushariara
Copy link

Dear mydea,

What i found in this addon is you missed to include ember-power-select.
without that it will showing error or missing html position.

after i added ember-power-select then nothing error and nothing miss html position.

@mydea
Copy link
Owner

mydea commented Aug 10, 2018

Hmm, this does not depend on ember-power-select, but on ember-basic-dropdown.
I have an idea, though.

Could you try uninstalling ember-power-select and installing the ensure-basic-dropdown-works branch of this? (you can do this by setting the version in your package.json to "mydea/ember-basic-dropdown#ensure-basic-dropdown-works")

I tried something there, let's see if it works!

@stepanushariara
Copy link

stepanushariara commented Aug 23, 2018

screen shot 2018-08-23 at 7 06 09 pm

In my local works good but I've got error basic-dropdown in my server. there's nothing special settings in my Server.
Please advice..

@mydea
Copy link
Owner

mydea commented Aug 23, 2018

Are you running the recently released 1.2.0? I made some changes there where I thought they might fix this.

@stepanushariara
Copy link

i use 1.1.5.
let me try this version.
some update will inform soon

@stepanushariara
Copy link

stepanushariara commented Aug 23, 2018

Still got same error with newest version

@mydea mydea closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants