Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Enhancement ] Automatically determine when a table should not use --innodb-optimize-keys #389

Closed
davidducos opened this issue Aug 5, 2021 · 2 comments · Fixed by #732 or #734
Closed

[ Enhancement ] Automatically determine when a table should not use --innodb-optimize-keys #389

davidducos opened this issue Aug 5, 2021 · 2 comments · Fixed by #732 or #734
Labels
enhancement
Milestone
Release 0.12.5-1

Comments

@davidducos
Copy link
Member

Currently --innodb-optimize-keys is applied to none or all the tables. We need to develop a formula to determine if it should be used per table basis.
@davidducos davidducos added this to the Release 0.10.11 milestone Aug 5, 2021
@davidducos davidducos mentioned this issue Aug 18, 2021
Closed
@davidducos
Copy link
Member Author

We also need to discards the tables that has constraint with ON DELETE CASCADE ON UPDATE CASCADE or other options that makes impossible to execute the ALTER TABLE statements in another import stage.

@davidducos davidducos changed the title [ Enhancement ] Automatically determine when a table should use --innodb-optimize-keys [ Enhancement ] Automatically determine when a table should not use --innodb-optimize-keys Sep 29, 2021
@davidducos
Copy link
Member Author

We need to develop a (parametrized) formula to flag as unsuitable the small table based on amount of rows and indexes length.

Reference: https://www.percona.com/blog/2015/01/21/importing-big-tables-large-indexes-myloader/

@davidducos davidducos linked a pull request Jun 17, 2022 that will close this issue
Automatically determine when a table should not use --innodb-optimize-keys #732
Merged
@davidducos davidducos linked a pull request Jun 19, 2022 that will close this issue
Automatically determine when a table should not use --innodb-optimize-keys #734
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 0.12.5-1
1 participant
@davidducos