Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thinks mouse is held down when switching back from another app? #10

Open
gingerbeardman opened this issue May 6, 2019 · 15 comments
Open
Labels
bug Something isn't working

Comments

@gingerbeardman
Copy link

gingerbeardman commented May 6, 2019

Most often I see a selection marquee which means this has happened.

Reproduce

  • Switch away from RPCEmu by clicking on another macOS application window.
  • That click seems to be noticed by RPCEmu.

Workaround

  • Click on the desktop when you return (cure)

or

  • Use Cmd+Tab to switch away from RPCEmu (prevention)
@myelin myelin added the bug Something isn't working label May 6, 2019
@myelin
Copy link
Owner

myelin commented May 7, 2019

Oddly, I used to get this all the time, but I can't reproduce it right now.

@gingerbeardman
Copy link
Author

I'll make a video for tomorrow

@gingerbeardman
Copy link
Author

gingerbeardman commented May 7, 2019

Video: https://imgur.com/a/ubuwEKk

Just stack some windows and click on an overlaying one?

@Septercius
Copy link

I can't reproduce it either. It was an issue with earlier versions of the patch, but I fixed that particular issue, which I think someone on Stardot kindly identified for me.

@gingerbeardman
Copy link
Author

I'm happy to try another build when one becomes available

@gingerbeardman
Copy link
Author

gingerbeardman commented May 8, 2019

This seems to be related to #6 (now retitled "Missed mouse clicks")

If I use artificially long single-clicks to switch apps, then everything is fine.

I always use Magic Mouse and can reproduce every time.

@myelin were you using different clicking devices when you were able to reproduce compared to not?

@myelin
Copy link
Owner

myelin commented May 12, 2019

I haven't pulled in Timothy's latest patch, but in my current build, I can reproduce this by trying to change the file type of a bunch of files:

  • Select two-button mouse mode.
  • Ctrl-click on one file, navigate through menus to Set Type, type "zip", hit ENTER.
  • Attempt to ctrl-click on next file -- nothing happens.
  • Click on the file without holding down any keys -- it acts as if you've held down the mouse button, and you end up stuck in drag mode.

I'll pull in the latest patch and see if this fixes it, but this seems to reliably reproduce it for me. This is with the -pp2 recompiler release.

@gingerbeardman
Copy link
Author

@myelin does it do the same if you use artificially long mouse clicks?

@myelin
Copy link
Owner

myelin commented May 12, 2019

After applying the patch, in RO5.27 under either the recompiler or interpreter build, even a single ctrl-click now triggers this behaviour. I tried making it a long click, but the same thing happened. I'm using the touchpad on a 2015 MBP.

If I plug in an external mouse and use the real middle button, everything works fine. Could this be a touchpad-specific thing? Or are you seeing it with a real mouse too?

@gingerbeardman
Copy link
Author

gingerbeardman commented May 12, 2019

I haven't used a touch pad with RPCEmu. Just a Magic Mouse. That's kind of a touch device though right? Hmm.

@gingerbeardman
Copy link
Author

gingerbeardman commented May 12, 2019

Still present in 0.9.1-pp3

I still think this is related to #6

The easiest way to reproduce is to move the mouse horizontally across the desktop and left click whilst continuing to move the mouse. Not so easy with touch pad.

Recording https://imgur.com/a/xb7yixR

@gingerbeardman
Copy link
Author

gingerbeardman commented May 12, 2019

If I do the click-whilst-moving test using a slightly longer click depress, then this does not happen.

Recording: https://imgur.com/a/SicPPFQ

@gingerbeardman
Copy link
Author

gingerbeardman commented May 12, 2019

Tested (identical results)

@zedtoo-de
Copy link

I don't know if it's relevant, but...

Control-clicking with a real mouse (i.e. not a touchpad) starts a click-and drag, which is finished by clicking on Adjust. I don't recall seeing this documented anywhere, but it might explain some of the oddities we're seeing (e.g. it may be that RPCEmu is seeing keyboard events as well as mouse movement when you switch to another application).

@gingerbeardman
Copy link
Author

gingerbeardman commented May 12, 2019

I'm not sure; I switch apps by clicking only. The issue doesn't happen if I switch apps by Cmd+Tab (not Control).

Unless there are spurious keyboard events happening?

But really I think this is all tied to the mouse down/up sensing, and the time interval between the two. Is that in Qt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants