Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBP control-fn-right doesn't exit full-screen mode #12

Closed
myelin opened this issue May 7, 2019 · 3 comments
Closed

MBP control-fn-right doesn't exit full-screen mode #12

myelin opened this issue May 7, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@myelin
Copy link
Owner

myelin commented May 7, 2019

Describe the bug
The dialog that pops up when you enter full-screen mode says to hit Ctrl-END to exit. END is fn-right on a MacBook Pro keyboard, so the expectation here is that control-fn-right will exit full-screen mode, but in reality it does nothing.

To Reproduce

  1. Settings | Full-screen Mode
  2. Click through dialog
  3. When in full-screen mode, hit control-fn-right
  4. Nothing happens

System information (please complete the following information):

  • machine: MBP 15" mid-2015
  • rpcemu-macos release: 0.9.1-pp2
  • macOS version: Mojave
  • Emulated processor: ARMSA
  • RISC OS version: 5.24
@myelin myelin added the bug Something isn't working label May 7, 2019
@Septercius
Copy link

Having looked at the code, there is at least one issue with the CTRL+END detection code, as it looks at the key event modifier state to determine whether CTRL is held down. This information isn't populated on the Mac, and you have to use a different way of detecting modifier key presses and releases (see the "keyboard_macosx.c" file).

This will need a change to expose the modifier state outside the mentioned file, which can then be picked up by the CTRL+END . This should (hopefully) be fairly straightforward.

@Septercius
Copy link

I've fixed this, so it can be included in the next patch which I'll submit to the RPC mailing list as normal.

@myelin
Copy link
Owner Author

myelin commented May 12, 2019

Confirmed that this is fixed in https://github.com/myelin/rpcemu-macos/releases/tag/0.9.1-pp3. Thanks!

@myelin myelin closed this as completed May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants