Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isort action comments to whitelist #33

Merged
merged 2 commits into from Apr 1, 2022
Merged

add isort action comments to whitelist #33

merged 2 commits into from Apr 1, 2022

Conversation

Cielquan
Copy link
Contributor

fixes #15 (comment)

@Cielquan
Copy link
Contributor Author

@sobolevn Could you take a look.
I directly added all currently available "isort action comments"

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sobolevn
Copy link
Member

But, we need to setup GitHub Actions before I can merge this.
Do you want to convert travis into GA? 🙂

@Cielquan
Copy link
Contributor Author

Cielquan commented Apr 1, 2022

But, we need to setup GitHub Actions before I can merge this. Do you want to convert travis into GA? slightly_smiling_face

Is there a specific reason for transition? Because this project does not see changes often, the relation between time-investment and benefits seem off to me.

But I will take a look at the current config and if it is not that much to do I think I will.

@Cielquan Cielquan mentioned this pull request Apr 1, 2022
@sobolevn sobolevn closed this Apr 1, 2022
@sobolevn sobolevn reopened this Apr 1, 2022
@sobolevn sobolevn merged commit 1f98dc4 into PyCQA:master Apr 1, 2022
@Cielquan Cielquan deleted the patch-1 branch April 1, 2022 20:04
@Cielquan
Copy link
Contributor Author

Cielquan commented Apr 5, 2022

@sobolevn Do you plan to make a new release soon? I guess you are waiting for #31 ?

@sobolevn
Copy link
Member

sobolevn commented Apr 5, 2022

Yes!

You can cherry-pick 123381d and add tests yourself if you wish.

Then I can make a new release sooner! 🙂

@Cielquan
Copy link
Contributor Author

Cielquan commented Apr 5, 2022

I probably will do so in the afternoon when I have time.

@sobolevn
Copy link
Member

sobolevn commented Apr 5, 2022

Thank you ❤️‍🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type ignore comments is a false positive.
2 participants