Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem on old versions of chrome #3

Open
danielebruni opened this issue Mar 13, 2021 · 3 comments
Open

Problem on old versions of chrome #3

danielebruni opened this issue Mar 13, 2021 · 3 comments

Comments

@danielebruni
Copy link

danielebruni commented Mar 13, 2021

Hi Isaak

First of all thank you for the great work.

I'm facing a problem with old versions of chrome and webkit based browsers on android (chrome, edge etc.).

The exception i'm getting is

Uncaught TypeError: wasm function signature contains illegal type
    at /wasm-function[11]:28
    at /wasm-function[63]:34
    at /wasm-function[62]:7
    at scanImage (zbar-wasi.esm.js:5186)
    at renderLoop ((index):25)
    at track ((index):70)
    at HTMLVideoElement.domVideo.addEventListener ((index):62)

I was able to reproduce it by using an old version of chromium for windows 72.0.3579.0, which can be downloaded here:

https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win_x64/599392/

I have reasons to believe that this exception is also causing #2 , since in the past I noticed a certain coherence between the behaviours of this version of chrome and iOS Safari.

This is as far as I can reach with my limited knwledge of wasm.

Could you please look into it?

Thank you again

Daniele

@myisaak
Copy link
Owner

myisaak commented Mar 29, 2021

Hi Daniele. Thanks for your issue submission. Perhaps at the end of this week I'll have time to look into it. When I do I'll keep you in touch :)

@tomriley
Copy link

I've fixed this issue by incorporating polyfills for the wasi calls involving i64 types: https://github.com/tomriley/zbar-wasi/tree/fix-ios#fixios

Solution comes from here: https://github.com/swiftwasm/swiftwasm-pad/tree/master/Frontend/Sources/i64_polyfill

Also fixes #2

@myisaak
Copy link
Owner

myisaak commented May 24, 2021

Thanks @tomriley for providing a solution. Feel free create a pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants