Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication in unit tests #10

Closed
MylesFTOP opened this issue Mar 8, 2020 · 1 comment
Closed

Remove duplication in unit tests #10

MylesFTOP opened this issue Mar 8, 2020 · 1 comment
Assignees
@MylesFTOP
Labels
bug Something isn't working
Projects
LuhnCheck planning

Comments

@MylesFTOP
Copy link
Owner

Currently, the unit tests exhibit duplication in the code used by test methods. These can be simplified by extracting the parameters in the methods and passing them back as arguments to fewer methods.
@MylesFTOP MylesFTOP added the bug Something isn't working label Mar 8, 2020
@MylesFTOP MylesFTOP self-assigned this Mar 8, 2020
@MylesFTOP MylesFTOP added this to To do in LuhnCheck planning Mar 9, 2020
@MylesFTOP
Copy link
Owner Author

MylesFTOP commented Jun 11, 2020 •
edited
Loading

Converted facts to theories and passed test values as inline data. Tests still pass. Committed in d3160c0.

LuhnCheck planning automation moved this from To do to Done Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MylesFTOP MylesFTOP

Labels
bug Something isn't working
Projects
LuhnCheck planning
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MylesFTOP