New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallback for os_name if user name is not defined #87

Merged

xzkostyan merged 1 commit into mymarilyn:master from wawaka:os_name_fallback_to_uid

May 21, 2019

Contributor

wawaka commented May 17, 2019

got this error while running inside docker container (no user entry for such uid)

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/clickhouse_driver/client.py", line 119, in execute
    columnar=columnar
  File "/usr/local/lib/python3.7/site-packages/clickhouse_driver/client.py", line 188, in process_ordinary_query
    self.connection.send_query(query, query_id=query_id)
  File "/usr/local/lib/python3.7/site-packages/clickhouse_driver/connection.py", line 432, in send_query
    client_info = ClientInfo(self.client_name)
  File "/usr/local/lib/python3.7/site-packages/clickhouse_driver/clientinfo.py", line 38, in __init__
    self.os_user = getpass.getuser()
  File "/usr/local/lib/python3.7/getpass.py", line 169, in getuser
    return pwd.getpwuid(os.getuid())[0]
KeyError: 'getpwuid(): uid not found: 1001'

coveralls commented May 17, 2019 •

edited

Coverage decreased (-0.07%) to 96.136% when pulling 1c59b79 on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

28 similar comments

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

coveralls commented May 17, 2019

Coverage decreased (-0.07%) to 96.138% when pulling fafc3db on wawaka:os_name_fallback_to_uid into 4592862 on mymarilyn:master.

Member

xzkostyan commented May 20, 2019

Hi. It seems this is a docker issue which hopefully can be fixed with useradd in Dockerfile.

But if we focus on code: os.getuid is linux-specific call. I've successfully tested this driver under Windows as well.

Fix shouldn't brake this OS-compatibility. I think it's OK to send os_user = 'unknown' in this case.

Contributor Author

wawaka commented May 20, 2019

What about set it to '' since unknown can be a valid name?

Member

xzkostyan commented May 20, 2019

OK, let's set to user name to empty string in this case.


          fallback for os_name if user name is not defined

1c59b79

wawaka changed the title ~~set os_name to str(uid) if user name is not defined for current uid~~ fallback for os_name if user name is not defined

xzkostyan merged commit 9dd6ca0 into mymarilyn:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment