Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #59

Open
lordazzi opened this issue Apr 5, 2021 · 9 comments
Open

TypeScript support #59

lordazzi opened this issue Apr 5, 2021 · 9 comments

Comments

@lordazzi
Copy link

lordazzi commented Apr 5, 2021

Hello, good afternoon.
I'm using your lib as a part of a project in angular,
but typescript compatibility is necessary,
so I wrote the typescript definitions files and now it is just ready to be published in microsoft @DefinitelyTyped repository.

If I got your bless, I will create a pull request to microsoft create the @types/vanillajs-datepicker package.

@mymth
Copy link
Owner

mymth commented Apr 12, 2021

Please feel free to do it.

@GigaGyrfalcon
Copy link

Is any news about it?

@lordazzi
Copy link
Author

Yes, I'm waiting for my in home vacation into July. Then I will test some interfaces that I already written and publish this.

@Honatas
Copy link

Honatas commented Jul 18, 2021

I'd also love to have these. Any news ?

@ichorville
Copy link

@lordazzi @mymth Hello, any update on this ? Anyone that could direct me to achieve this for this lib, it has become a blocker for me when upgrading my project from angular 11 to angular 13.

@rougin
Copy link

rougin commented Nov 23, 2022

Hello! This thread might be outdated but I tried npm i --save-dev @types/vanillajs-datepicker and I can now import the library properly in Typescript.

@mmouterde
Copy link

mmouterde commented Mar 4, 2024

Thanks @rougin, but how do you deal with locale ?

@rougin
Copy link

rougin commented Mar 4, 2024

Thanks @rougin, but how do you deal with locale ?

Hi, I'm really not sure on how to answer this one as I did not use a specified locale for this package. However, as I checked from their documentation, the package supports i18n: https://mymth.github.io/vanillajs-datepicker/#/i18n

@mmouterde
Copy link

Thanks for your reactivity !
I followed the documentation but typescript is not aware of the locales directories :/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants