Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditional unregistration? #94

Closed
davidkarlsen opened this issue Mar 11, 2021 · 3 comments · Fixed by #101
Closed

conditional unregistration? #94

davidkarlsen opened this issue Mar 11, 2021 · 3 comments · Fixed by #101

Comments

@davidkarlsen
Copy link

davidkarlsen commented Mar 11, 2021

Hi - I have a similar image in https://github.com/evryfs/github-actions-runner, but think I could maybe drop it in favour of this one.
I manage the pods with https://github.com/evryfs/github-actions-runner-operator
The operator handles unregistration, and hence I'd like to avoid the runner pod to attempt to do this itself in https://github.com/myoung34/docker-github-actions-runner/blob/master/entrypoint.sh#L43

Would you accept to make that step conditional by passing some var?

@myoung34
Copy link
Owner

Totally doable! Id prefer to keep changes backwards compatible at the sake of a --no-{} flag|env var if that's fine (usually i don't like no flags vs just flags)

Something like DISABLE_AUTOMATIC_DEREGISTRATION (or something similar) ?

@davidkarlsen
Copy link
Author

Totally doable! Id prefer to keep changes backwards compatible at the sake of a --no-{} flag|env var if that's fine (usually i don't like no flags vs just flags)

that makes perfect sense

Something like DISABLE_AUTOMATIC_DEREGISTRATION (or something similar) ?

sounds perfect

@myoung34
Copy link
Owner

@davidkarlsen If you'd like to review I have a PR up at #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants