Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sentences do not need to be marked as translatable. #1002

Closed
ghost opened this issue May 3, 2019 · 4 comments
Closed

Some sentences do not need to be marked as translatable. #1002

ghost opened this issue May 3, 2019 · 4 comments

Comments

@ghost
Copy link

ghost commented May 3, 2019

I'm not 100% sure but in my opinion, we don't need to mark as translatable these sentences.

These sentences have taken from MyPaint 2.x master branch.

#. TRANSLATORS: footer icon tooltip markup for the current mode
#. TRANSLATORS: tooltip for the layer mode dropdown (markup)
#: ../gui/drawwindow.py:106 ../gui/layerswindow.py:81
#, python-brace-format
msgid ""
"<b>{name}</b>\n"
"{description}"
msgstr ""
"<b>{name}</b>\n"
"{description}"

#. TRANSLATORS: window title for use with a filename
#: ../gui/drawwindow.py:298
#, python-format
msgid "%s - MyPaint"
msgstr "%s - MyPaint"

#. TRANSLATORS: window title for use without a filename
#: ../gui/drawwindow.py:301 ../po/tmp/mypaint.glade.h:1
msgid "MyPaint"
msgstr "MyPaint"

#: ../gui/footer.py:191
#, python-brace-format
msgctxt "current brush indicator: tooltip (no-description case)"
msgid "<b>{brush_name}</b>"
msgstr "<b>{brush_name}</b>"

#: ../gui/footer.py:196
#, python-brace-format
msgctxt "current brush indicator: tooltip (description case)"
msgid ""
"<b>{brush_name}</b>\n"
"{brush_desc}"
msgstr ""
"<b>{brush_name}</b>\n"
"{brush_desc}"

#: ../gui/layers.py:990
#, python-brace-format
msgctxt "Layers dockable: markup for a layer with no description"
msgid "{layer_name}"
msgstr "{layer_name}"

#: ../gui/layers.py:995
#, python-brace-format
msgctxt "Layers dockable: markup for a layer with a description"
msgid ""
"<span size=\"smaller\">{layer_name}\n"
"<span size=\"smaller\" alpha=\"50%\">{layer_description}</span></span>"
msgstr ""
"<span size=\"smaller\">{layer_name}\n"
"<span size=\"smaller\" alpha=\"50%\">{layer_description}</span></span>"

# fuzzy: çevirmeye gerek yok
#: ../gui/layervis.py:53
#, python-brace-format
msgctxt "view controls: dropdown: item markup"
msgid "<i>{builtin_view_name}</i>"
msgstr "<i>{builtin_view_name}</i>"

#: ../gui/layervis.py:125
#, python-brace-format
msgctxt "view controls: dropdown: item markup"
msgid "{user_chosen_view_name}"
msgstr "{user_chosen_view_name}"

#: ../gui/optionspanel.py:58
#, python-brace-format
msgctxt "options panel: header"
msgid "<b>{mode_name}</b>"
msgstr "<b>{mode_name}</b>"

#: ../gui/topbar.py:91
msgid "<b>MyPaint</b>"
msgstr "<b>MyPaint</b>"

#: ../lib/naming.py:22
#, python-brace-format
msgctxt "unique names: serial number needed: template"
msgid "{name} {number}"
msgstr "{name} {number}"

#: ../lib/naming.py:29
msgctxt "unique names: regex matching a string with a serial number"
msgid "^(?P<name>.*?)\\s+(?P<number>\\d+)$"
msgstr "^(?P<name>.*?)\\s+(?P<number>\\d+)$"

#: ../po/tmp/brusheditor.glade.h:39
msgid "{tooltip}"
msgstr "{tooltip}"

#. field name (template)
#: ../po/tmp/brusheditor.glade.h:41
msgid "{dname}:"
msgstr "{dname}:"

@don570
Copy link

don570 commented May 4, 2019

In graphics programs there are some effects like filters that are untranslatable or aren't worth
translating such as an effect that is named after a person's name.
An example 'Bokeh' is now very common term in graphics apps...
https://en.wikipedia.org/wiki/Bokeh
Gaussian blur is another term

@tjhietala
Copy link
Contributor

There's nothing inherently untranslatable about 'Gaussian blur' or 'bokeh'. The choice of translating or not translating should be left to the translators of each language.

@jplloyd
Copy link
Member

jplloyd commented Jul 12, 2019

Some of these do seem redundant, but for the ones with two parts/sections I could see the potential necessity of letting translators reorder components by the convention of their language (right-to-left languages in particular, I guess). I am no i18n expert, but that seems like one reason to keep those.

@jplloyd
Copy link
Member

jplloyd commented Jul 23, 2019

Based on my (admittedly limited) understanding of doing i18n for rtl scripts, it seems most of these instances do need to be marked as translatable. The only one I cannot see any reason for is {tooltip} (notice the colon in the {dname} instance), but seeing as most languages will just copy these verbatim (if we want to keep track of completion) or leave them empty, I think we can overlook that one.

@jplloyd jplloyd closed this as completed Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants