Color picker icon doesn't appear when holding Ctrl key

[Deevad]

Hi,

Problem:
If you hold Ctrl on keyboard over the canvas , it's currently hard to see your tool changed for a color-picker. Only the caption on the footer-bar change. You need to click on canvas to make the color preview and color-picker icon appearing.

Expected behavior:
As soon as Ctrl is pressed, the brush outliner change to a color-picker.

Reproducible: always

[achadwick]

Hi David --

Semi-confirmed in git master as of 27225a3 - but I'm not sure this is a bug.

What do you mean by "brush outliner" - just the cursor?

I note that the cursor changes when is held if and only if there are no other button bindings other than Button1 which start with with a modifier. This in fact is the intended behaviour: if there is, for example, a pair of bindings Button1 and Button2, then if is held down one cannot assume that the subsequent button press will be Button1.

The reason for this seeming intolerance of ambiguity ☺ is that the colour picker is implemented as a separate mode (tool), and when entered, the mode cannot be switched out of by pressing more modifier keys. If the picker were switched to immediately, other bindings would not operate.

tl;dr - the old behaviour can be restored by removing the default binding of Button2 to Zoom View.

("" is GTK3's spelling of "". They refer to the same key.)

[Deevad]

<Primary> is GTK3's spelling of <Control>

Oh good to know

What do you mean by "brush outliner" - just the cursor?

For me, the 'brush outliner' describes the circle lined cursor for brush ; often with a similar diameter than the brush. Eg. :

the old behaviour can be restored by removing the default binding of Button2 to Zoom View.

Oh good to know there is an immediate workaround. I need a bit of precision before picking a color, and the "brush outliner" isn't enough good for performing this. I pick a lot during painting. I tested and it works. Thanks.

This in fact is the intended behaviour if there is, for example, a pair of bindings <Primary>Button1 and <Primary>Button2, then if <Primary> is held down one cannot assume that the subsequent button press will be Button1.

I understand. It's logical on the software side, and 'tool binding' side logic too.
But when I hold <primary> the current "brush outline" cursor is not enough precise for me to pick/click on canvas the color I want. That's why I like when a color-picker cursor appear when <primary> is held. Also, Gimp, Krita, Ps, Painter, and other painting software does it this way.

[achadwick]

Deferring until after the 1.2 release. Fiddling with the behaviour of "modifier keys" (really mode switching) generally leads to more mess elsewhere, and there's already quite a bit of that affecting this bit of the code (e.g. #253).

[mukuljainx]

@achadwick , I really dont think this one is a bug or issue, other painting may do in that other way but we don't, simple. While pressing "crtl" I got two option mentioned in footer-bar, one to choose outline and one for other work, so crtl just cant give you color picker and it dosent mean that way too, user have to understand, whats your opinion?

[odysseywestra]

Another workaround is to use the "r" key since now that is also the default shortcut for color picker as well.