Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSL Saturation Modelling - Wet Brushes and around #256

Closed
americogobbo opened this issue Mar 12, 2015 · 5 comments
Closed

HSL Saturation Modelling - Wet Brushes and around #256

americogobbo opened this issue Mar 12, 2015 · 5 comments

Comments

@americogobbo
Copy link

I'm working on the wet brushes set. They are very interesting to use but I am not capable to resolve the relationship between with the grey values and HSL saturation instances... always the greys are changing the Hue... they appear redish... Perhaps is not possible to do it.
With other colors works fine my problem is only to modelling de grey tones.
In this model I'm using basically the Opacity and Color HSL saturation.
Some suggestion?
http://pastebin.com/Y7wJjY84 (brush)

@iirelu
Copy link
Contributor

iirelu commented Mar 12, 2015

Screenshots of what it looks like?

@americogobbo
Copy link
Author

weting-proofs-grey-problem

The problem is only with the greys... white works well. Perhaps some detail on my brush model.

@0ion9
Copy link
Contributor

0ion9 commented Mar 13, 2015

@americogobbo :

"The problem is only with the greys... white works well."

That sounds like a bug. The problem should also occur with white and black. It's a problem that is inherent in the HSL model: A color with no saturation (ie. a pure grey) has no real hue, so an arbitrary hue value (usually 0, which is red) is used whenever converting from RGB.
I think we work with HSL as much as possible inside the brush engine to avoid hitting this type of problem, but it seems that there is some codepath where we end up converting to RGB and back then storing the new color (with hue value of 0) in the brush HSL info.

@americogobbo
Copy link
Author

Ok, I understood. Can I help to clarify this problem with some task?

@achadwick
Copy link
Member

I see it now. Affects "Change color satur. (HSV)" and "Change color satur. (HSL)".

This is a brush engine issue I guess. Closed in favour of mypaint/libmypaint#15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants