Pharo8 : improve code completion for temps

[myroslavarm]

when declaring temps, they get completed. they shouldn't because we are essentially making up new variables

[MarcusDenker]

is this still a problem in Pharo8? When I tried it did not complete them anymore

[MarcusDenker]

double check: the old completion wants to complete temp var declarations, the new one does not.

Which I think is better.

[myroslavarm]

update :
test completion works well
new model should be fixed

[myroslavarm]

should be fixed in : b1e5b30.
the problem was that because of caching method suggestions and interpreting temp declaration as part of the method, the only suggestion for temps was the name of the class it's in. i have now changed it to no completion, because a) it was totally incorrect b) temp declaration should not be completed

[MarcusDenker]

It is now disabled, but it might be interesting later to find a way to suggest something |forThis |

(future work)

[MarcusDenker]

this is fixed

[myroslavarm]

FINALLY fixed in this commit : pharo-project/pharo@ddc49cd. temps don't get completed but methods do, and everything works! again, the problem was with error node