Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method definition competion #60

Closed
myroslavarm opened this issue Jul 16, 2019 · 3 comments
Closed

add method definition competion #60

myroslavarm opened this issue Jul 16, 2019 · 3 comments

Comments

@myroslavarm
Copy link
Owner

the line
(self methodNames includes: aRBMethodNode) ifFalse: [ ^#() ].
in MatchedNodeProducer >> visitMethodNode: aRBMethodNode
gets rid of the incorrect temp definition completion, but also stops method definitions from being completed. we need to figure out a way to fix it

@MarcusDenker
Copy link

This is closed: method definitions are now completed. The workaround stays for not completing temp definitions, which does not work yet

@myroslavarm
Copy link
Owner Author

reopened because while the workaround exists method definitions are not completed :(

@myroslavarm
Copy link
Owner Author

fixed in this commit : pharo-project/pharo@ddc49cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants