Added support for SST25 Series SPI Flash (e.g. from Microchip) for OTA

[D-H-R]

Updated SPI-Flash to support SST25 Series of SPI Flash, which does not support page programming with opcode 0x02, but Automatic Address Increment Word programming with opcode 0xAD. Use #define SPIFLASH_SST25TYPE for SST25 Type Flash Memory and AAI Word Programming.

Further Info on Forum: https://forum.mysensors.org/topic/3160/ota-flash-types-for-mysensors/14

CLA Hub seems that it is not working for me :( However: "I agree to CLA"
Update: CLA seemed to work now..
Regards Dirk_H / D-H-R

[mysensors-jenkins]

I found warnings (compiler or Doxygen related) in the MySensors core library when building the core library verification sketches. Please rebuild your changes locally with all warnings enabled in the Arduino IDE and make sure it compiles cleanly and resubmit your changes. You do not need to resolve warnings that are unrelated to your change.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoLibPR/153/
Compiler warnings exist in the Subproject Builds marked with yellow. Click the yellow dot and then on "Arduino/AVR warnings" to review the warnings reported.
Doxygen warnings are reported here: http://ci.mysensors.org/job/MySensorsArduinoLibPR/153/warnings14Result
A member of the MySensors core team can retrigger a build on this exact commit by telling me "jenkins, build this please".
But remember that I will only listen if you name me with a capital 'J'.
If the PR is updated I will rebuild it automatically.

[D-H-R]

Hmmm.. I'm not very familiar with doxygen and do not know what to do... Can someone help me with that please ?

[henrikekblad]

Hmm,.. there seem to be a #define inside the comment, referring to something none existing.. if you remove the #-character it might not try to refer it...

https://ci.mysensors.org/job/MySensorsArduinoLibPR/153/warnings15Result/new/NORMAL/

[mysensors-jenkins]

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

[henrikekblad]

Please follow the MySensors naming "standard".
I.e. **MY_**SPIFLASH_SST25TYPE
You should also add it to the keywords.txt file.

Thanks!

[D-H-R]

Hi,
I thought about this already and I'm not sure if we should do this directly. I have the feeling SPIFlash.c is like a third Party library.
Do you think I should change the define or might a wrapper in the MySensor.h file be better? Something like ifdef MY_SPIFLASH_SST25TYPE define SPIFLASH_SST25TYPE in the MySensor.h.

I hope you understand what I mean. :)

[henrikekblad]

I's ok as we already this for our local drivers in the MySensors package. I.e RF24.

[mysensors-jenkins]

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

[henrikekblad]

Jenkins, build examples please.

[mysensors-jenkins]

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoPR/450/

[fallberg]

@D-H-R next time, please follow this guide to writing git commit messages: http://chris.beams.io/posts/git-commit
Long commit headlines make the git log difficult to read and for this reason there have been "standards" developed.
If you have any question, just ask :)