Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pro base path /pro rather than /alaveteli_pro #7788

Closed
1 task done
garethrees opened this issue Jun 21, 2023 · 5 comments
Closed
1 task done

Make Pro base path /pro rather than /alaveteli_pro #7788

garethrees opened this issue Jun 21, 2023 · 5 comments
Labels
f:framework improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) professional x:uk

Comments

@garethrees
Copy link
Member

garethrees commented Jun 21, 2023

/alaveteli_pro doesn't look right. Lets change it to /pro.

After #7787 there shouldn't be any need to add redirects for /alaveteli_pro-prefixed routes, but we'll want to be sure before shipping this.

@garethrees garethrees added x:uk professional improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) f:framework labels Jun 21, 2023
@laurentS
Copy link
Contributor

Could I suggest making the /pro replacement configurable if it's not a huge amount of work?

@garethrees
Copy link
Member Author

We can certainly explore that as an option, though routes aren't quite as easy to customise. What would you use instead?

@laurentS
Copy link
Contributor

I think your "not quite as easy" comment is enough for me to say it's not worth it. We have tried to avoid the "pro" word, but we're still using english URLs and all, so I think it says it's not a big priority. (we call it "plusplus / ++" for madada)

@LisetHamming
Copy link

LisetHamming commented Feb 2, 2024

Hi Gareth and Laurent! Probably not the best place to leave personal notes, but wanted to let you know that I made it this far (where are the smileys in this place...) and am exploring, thanks to you! There is a lot to see here...

See you soon!

Ps ha, did discover a few smileys by accident👍

@garethrees
Copy link
Member Author

In planning today @alexander-griffen noted that he and @gbp had noted some potential complexity with this change. I had a quick look at the routes and while I'm not 100% sure, I can see that all this might be more annoying than a simple word change. If it's easier, we could make this /dashboard, which would also be more agnostic to what different sites call their pro offering. I'm leaning towards preferring /dashboard anyway – it more closely describes what the user is looking at, and it's served by the DashboardController.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:framework improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) professional x:uk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants