Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no reports on map, "sort by" doesn't work #1577

Closed
abibroom opened this issue Nov 17, 2016 · 1 comment
Closed

If no reports on map, "sort by" doesn't work #1577

abibroom opened this issue Nov 17, 2016 · 1 comment

Comments

@abibroom
Copy link

https://www.fixmystreet.com/around?pc=PO17+6AR has no reports on the map (at time of writing!).

The list of reports shown in the sidebar is the fallback: closest 20 to that postcode. This means the "sort by" dropdown has no effect - even though the list of reports looks on first glance to be the same as any other list of reports - and thus appears to be broken.

Should perhaps say something like "No reports to show on map, here are some nearby ones" as a clue that this list of reports won't behave like other ones. Or make the sort work on those 20 reports regardless of whether they're on the map or not.

@dracos
Copy link
Member

dracos commented Nov 21, 2017

It does say the text mentioned above now, added as part of pagination. Think that should do; there's not much point in making the sort work because it is the 20 closest to the map, not necessarily the 20 newest/oldest etc, which it might make you think it was otherwise iyswim.

@dracos dracos closed this as completed Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants