Markup problem details role seems to be required in order for users to show up in the assignment dropdown

[jonkri]

Describe the bug

If a user is missing the Markup problem details role then that user doesn't seem to show up in the assignment dropdown in the inspection form. This is the case even if the user has the Manage shortlist permission.

To Reproduce

Steps to reproduce the behavior:

1. Create a body user with the following permissions: Create reports/updates as anonymous user, Create reports/updates as the council, Default to creating reports/updates as the council, Manage shortlist, Edit reports and Edit report category.
2. Try to assign a report to the body user created in Step 1.

Expected behavior

The user created in Step 1 above shows up in the assignment dropdown.

Screenshots

Not applicable.

Desktop (please complete the following information):

Not applicable.

Smartphone (please complete the following information):

Not applicable.

Additional context

Not applicable.

[jonkri]

Related to #4855, when a user doesn't show up in the dropdown because of this, and the same user shortlists the problem, the wrong user is displayed in the assignment dropdown.

[jonkri]

Would it make sense to display users with the Manage shortlist (planned_reports) permission in the assignment dropdown instead?

-[% inspectors = c.user.from_body.staff_with_permission('report_inspect') %]
+[% inspectors = c.user.from_body.staff_with_permission('planned_reports') %]

[dracos]

In our database, looks like we currently have:

• 1,191 users with both permissions
• 307 users with report_inspect but not planned_reports
• 9 with planned_reports but not report_inspect

I can't easily say whether any of those use the shortlist assignment or not, but from that I'd say whilst we could almost certainly add planned_reports to the list on top of report_inspect users, I don't think we could change it from one to the other.

[jonkri]

Interesting!

Adding planned_reports to the list on top of report_inspect users would work for us.

[dracos]

Although... having thought about it some more, is there any point to someone being able to be assigned if they can't then look at their shortlist? What do we do with this, would need a bit of looking to see what it's used for.