Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate bulk processing tool #38

Closed
6 tasks done
dracos opened this issue Feb 21, 2017 · 5 comments
Closed
6 tasks done

Integrate bulk processing tool #38

dracos opened this issue Feb 21, 2017 · 5 comments

Comments

@dracos
Copy link
Member

dracos commented Feb 21, 2017

Transferred from mysociety/mapit-bulk-processing#1

  • Design lookover of process
    • Form fields (column select, skip bad rows tickbox, pick which area types list, email/description)
    • Error messages
    • Table display
    • You'll get an email/download your CSV pages
  • Advertising this elsewhere on site => Advertise data mapper on the site #46
  • Copy for each step of process, success email
@dracos
Copy link
Member Author

dracos commented Apr 7, 2017

Just to note this is live at https://mapit.mysociety.org/bulk/ - I reused the front end code from accounts, so that looks okay, but the things above are the outstanding things potentially left.

@MyfanwyNixon
Copy link
Member

Here's a draft for some copy and the success email, plus error messages.
https://docs.google.com/document/d/1wo2pTTV26gdIz85rUgE4ODTV5IdUtuc4Yp-XsceCd9o/edit#

I've probably made some wrong assumptions so feel free to change it!

@zarino
Copy link
Member

zarino commented Apr 11, 2017

Notes on the visual elements:

  • The file input with the text input styling (because we’re re-using the .account-form__field styles) looks a bit funky, but I guess it's still usable. I can spend a little time fixing this if you want. => Bulk: Improve file upload field #47
  • "Next" buttons should have btn--primary not btn-primary class. (Sorry, this isn’t a Bootstrap site, despite the classes looking kinda similar.)
  • I wonder whether it'd make more sense to swap the vertical order of the "Now tell us where the postcodes are" and "This is what your file looks like" sections? So, first you show them what their file looks like, and then you ask them to make a selection from the dropdown and click "Next".
  • I’d probably put the "Prev" and "Next" buttons on the same line, in that order (rather than wrapping the "Prev" in a <p> after the "Next" button).
  • Also, any chance we could make the personal_details-email input a <input type="email"> rather than <input type="text">?

@MyfanwyNixon
Copy link
Member

MyfanwyNixon commented Apr 11, 2017

I wonder whether it'd make more sense to swap the vertical order of the "Now tell us where the postcodes are" and "This is what your file looks like" sections

I vote for this (though you'd need to only show a few lines I think - the depth it is at the moment, you'd run the risk of the text underneath being overlooked).

@dracos
Copy link
Member Author

dracos commented Apr 11, 2017

Most/all the above integrated, and live, moved bits to new tickets, considering this closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants