Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new character sets in MySQL 8.0 #242

Closed
bgrainger opened this issue Apr 17, 2017 · 2 comments
Closed

Support new character sets in MySQL 8.0 #242

bgrainger opened this issue Apr 17, 2017 · 2 comments

Comments

@bgrainger
Copy link
Member

bgrainger commented Apr 17, 2017

Run the SideBySide tests against MySQL Server 8.0.1; DataTypes.QueryBinaryGuid(false) fails:

Failed   SideBySide.DataTypes.QueryBinaryGuid(oldGuids: False)
Error Message:
 Assert.Equal() Failure
Expected: typeof(System.Guid)
Actual:   typeof(string)
Stack Trace:
   at SideBySide.DataTypes.QueryBinaryGuid(Boolean oldGuids) in MySqlConnector\tests\SideBySide\DataTypes.cs:line 346

Note that this failure doesn't happen when running just the QueryBinaryGuid tests, nor when setting csb.MaximumPoolSize = 1234; in the test, which indicates it may be related to pulling an existing connection from the pool.

The failure also doesn't reproduce when using MySql.Data 6.9.9.

@bgrainger bgrainger added the bug label Apr 17, 2017
@bgrainger
Copy link
Member Author

bgrainger commented Apr 18, 2017

For a passing test, the values on line 337 are:

ColumnLength CharacterSet BytesPerCharacter Computed Length Correct
144 Utf8Mb4Binary 4 36 ✔️

For a failing test, they are:

ColumnLength CharacterSet BytesPerCharacter Computed Length Correct
144 255 1 144

It appears that MySQL 8.0 has new characters sets that we need to support. Specifically, SELECT id, collation_name FROM information_schema.collations WHERE id > 250 ORDER BY id; lists 43 new character sets.

@bgrainger bgrainger changed the title QueryBinaryGuid fails with MySQL Server 8.0.1 Support new character sets in MySQL 8.0 Apr 18, 2017
@bgrainger bgrainger added enhancement and removed bug labels Apr 18, 2017
@bgrainger
Copy link
Member Author

bgrainger commented Apr 20, 2017

Fixed in 0.18.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant