Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls.createSecurePair is being runtime-deprecated #1650

Closed
ChALkeR opened this issue Feb 26, 2017 · 3 comments
Closed

tls.createSecurePair is being runtime-deprecated #1650

ChALkeR opened this issue Feb 26, 2017 · 3 comments
Assignees

Comments

@ChALkeR
Copy link

ChALkeR commented Feb 26, 2017

Ref: nodejs/node#11349

Used in:

mysql-2.13.0.tgz/lib/Connection.js:353:    var securePair         = tls.createSecurePair(credentials, false, true, rejectUnauthorized);

and tests.

Related: #737, sidorares/node-mysql2#367.

@dougwilson
Copy link
Member

dougwilson commented Feb 26, 2017

Since it;s in a block for old versions, we shouldn't be affected, right?

@ChALkeR
Copy link
Author

ChALkeR commented Feb 26, 2017

@dougwilson You are correct, I somehow missed that feature detection is also present here, sorry.

Closing this. I'm also guessing that #737 can be closed.

@ChALkeR ChALkeR closed this as completed Feb 26, 2017
@dougwilson dougwilson self-assigned this Feb 26, 2017
@dougwilson
Copy link
Member

Cool, just wasn't sure from reading the Node.js issue :) Yes, it is a large block. The older Node.js versions are getting on the chopping block for this module in the near future, so one day it'll be gone from the source :D Thanks for the warning on this deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants