Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Ability to edit Field Model data for FF7-PS1 #118

Closed
HeyItsLollie opened this issue Jul 20, 2021 · 6 comments
Closed

Request: Ability to edit Field Model data for FF7-PS1 #118

HeyItsLollie opened this issue Jul 20, 2021 · 6 comments
Assignees

Comments

@HeyItsLollie
Copy link

Hi Myst6re,
I was doing some tests with the directional lighting in FF7-PC during the last weekend, and I wanted to test the directional lighting in FF7-PS1 as well. But Makou Reactor currently locks all of the Field Model data for FF7-PS1. Is it possible to enable these controls?

Makou_Reactor_20210720_18-27-21-051

@jeromearz
Copy link

Hello, it is not a quick feature to do, so do not expect an implementation of this soon. I don't think it is really hard to make it happen in Makou, if someone can take a look I will gladly accept the PR

@jeromearz
Copy link

That's something I wanted to do from a long time now, because obviously PC behavior is completely different from the PS one.

@HeyItsLollie
Copy link
Author

I had a feeling it was disabled due to PS1/PC differences, that's understandable. I mostly just wanted to voice support for the feature!

Makou_Reactor_20210719_16-39-14-255

The main thing I found in my testing: In the opening scene, if you zero out these values for the second and third lights, you get a result that is similar to the lighting on PS1. The original lighting seems to still be in there. You can see how the light pinches on Cloud's forehead and the front of his pants, or how the gradients in his hair travel in similar directions. (The lighting is still much darker though, so it's not a complete solution.)

Cloud-Comparison-3

If PS1 support was there, I could see how the second and third lights affect Cloud on PS1. Hopefully there's someone out there who can look into this in the future!

@myst6re
Copy link
Owner

myst6re commented Aug 5, 2021

I pushed some changes to edit global light, directional lights and model scale on PS version
When available, can you try this build? https://ci.appveyor.com/project/myst6re/makoureactor/builds/40276730/job/l1e2wwycv724l3ku/artifacts

Edit: link updated

@HeyItsLollie
Copy link
Author

It works! Thank you for adding editable properties for the lighting, that alone helps a lot. 🙌

@myst6re
Copy link
Owner

myst6re commented Aug 30, 2021

Remaining tasks moved to another issue. Closing this ticket .

@myst6re myst6re closed this as completed Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants