Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLS12377] Add benchmarks for all functions and compare against 12381 #137

Closed
kchalkias opened this issue Oct 20, 2022 · 6 comments
Closed
Assignees

Comments

@kchalkias
Copy link
Collaborator

No description provided.

@kchalkias kchalkias changed the title [BLS12377] Add it to benchmarks for all functions [BLS12377] Add benchmarks for all functions and compare against 12381 Oct 20, 2022
@jonas-lj
Copy link
Contributor

@huitseeker mentioned that the implementation of BLS12377 is outdated. Should we update the implementation before we do the benchmarks, or should we just benchmark what we have?

@huitseeker
Copy link
Contributor

You'll want to at least turn on the "asm" feature of ark_ff for benches.

@jonas-lj
Copy link
Contributor

You'll want to at least turn on the "asm" feature of ark_ff for benches.

Sure, I'll make sure to do that. It doesn't seem to matter that much, though, at least for aggregate and batched signature verification.

@kchalkias
Copy link
Collaborator Author

Did we eventually include "asm" in our benchmarks?

@huitseeker
Copy link
Contributor

@kchalkias yes 6c78d86

@jonas-lj
Copy link
Contributor

There are benchmarks for all functions in the criterion report, so I think it's ok to close this issue now. Otherwise let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants